Fix racy tests sharing tests/data.out - #101
Merged
Merged
Conversation
streams_001, streams_002 and streams_004 all write, stat and unlink the very
same file tests/data.out. Since php-src 1d2ea5ce22c ("Run tests in parallel by
default", GH-22939, first released in php-8.6.0beta1) run-tests.php spawns
min(nproc, 10) workers by default, so these three tests race each other and
fail intermittently - filesize()/file_get_contents() hit a path a sibling test
has just unlinked.
Give each test its own scratch file, the way tests/dictionary_streams.phpt
already does.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe stream tests now write output to files derived from their test filenames instead of using the shared ChangesStream test output isolation
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
streams_001, streams_002 and streams_004 all write, stat and unlink the very same file tests/data.out. Since php-src php/php-src@1d2ea5ce22c ("Run tests in parallel by default", GH-22939, first released in php-8.6.0beta1) run-tests.php spawns min(nproc, 10) workers by default, so these three tests race each other and fail intermittently - filesize()/file_get_contents() hit a path a sibling test has just unlinked.
Give each test its own scratch file, the way tests/dictionary_streams.phpt already does.
Summary by CodeRabbit